Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all resource endpoints on resource grid #2413

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 26, 2024

Fixes #1489

  • Displays a merged list of endpoints/services in the dashboard grid
  • Only includes endpoint proxy URL. The underlying endpoint URL is still available in the details view.

The implementaiton is messy because:

  • The data is split between endpoint and service collections on a resource.
  • There is duplicate data between the two collections (endpoints appear to always have a service) and we don't want to display both
  • There isn't a good way to match endpoints to a service. Forced to parse endpoint URL to a Uri and match with host/port.
  • Services are immediately available while endpoints load in as they become available.

I think the model around endpoints and services returned from the resource service needs to be improved. At the very least, endpoints should have their service name to make matching them together easier.

Demo:
resources-endpoints

@davidfowl
Copy link
Member

I think the model around endpoints and services returned from the resource service needs to be improved. At the very least, endpoints should have their service name to make matching them together easier.

I'm filing an issue with protocol changes. I think we want to make it a bit more abstract as well (to support custom resources).

@davidfowl davidfowl added this to the preview 4 (Mar) milestone Feb 26, 2024
@davidfowl davidfowl mentioned this pull request Feb 26, 2024
6 tasks
@joperezr
Copy link
Member

Friendly reminder that this PR is assigned to the Preview 4 milestone which is snapping in a couple of hours. Please ensure it is merged by 4pm PST in order to ensure the change will be part of Preview 4.

@JamesNK JamesNK enabled auto-merge (squash) February 26, 2024 23:47
@JamesNK JamesNK merged commit aa497c2 into main Feb 27, 2024
8 checks passed
@JamesNK JamesNK deleted the jamesnk/resource-endpoints branch February 27, 2024 00:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show endpoints even if they aren't http
4 participants