Fix shortcuts changing multiple browser windows #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamint
approved these changes
Feb 27, 2024
adamint
pushed a commit
to adamint/aspire
that referenced
this pull request
Feb 27, 2024
* Fix shortcuts changing multiple browser windows * Clean up (cherry picked from commit fcadd63)
adamint
pushed a commit
to adamint/aspire
that referenced
this pull request
Feb 27, 2024
* Fix shortcuts changing multiple browser windows * Clean up (cherry picked from commit fcadd63)
joperezr
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Fix shortcuts changing multiple browser windows (#2470) * Fix shortcuts changing multiple browser windows * Clean up (cherry picked from commit fcadd63) * Fix keyboard shortcuts, url casing and JSDisconnectedException (#2466) * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 197c21e) * Untrack DialogReference when dialog is closed (#2465) * Untrack DialogReference when dialog is closed * Fix keyboard shortcuts and url casing * Suppress JSDisconnectedException * Check MetaKey and refactor modifier key checks * removed redundant extra OnDialogCloseRequested call --------- Co-authored-by: Adam Ratzman <[email protected]> Co-authored-by: Ratzman, Adam Mortimer <[email protected]> (cherry picked from commit 0a7b6c7) * Use OnDialogClosing instead of OnDialogResult to remove dialog reference in MainLayout (#2476) * Use OnDialogClosing instead of OnDialogResult * Remove redundant event listener --------- Co-authored-by: Adam Ratzman <[email protected]> (cherry picked from commit 1434b99) --------- Co-authored-by: James Newton-King <[email protected]> Co-authored-by: Tim Mulholland <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2467
Fixes #2459
ShortcutManagerto an instance type and inject with scope lifetimeIDisposable. We now rely on the implementing type to do clean up however it sees fit. This change was made because if a type implementsIDisposableandIAsyncDisposablethen onlyDisposeAsyncis called. This was causing leaks inMainLayoutwhich never called cleanup code inDispose. Each instance was never unregistered from the shortcut manager.Microsoft Reviewers: Open in CodeFlow