Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rabbitmq] Pass ConnectionFactory instead of IConnectionFactory to #2479

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

radical
Copy link
Member

@radical radical commented Feb 27, 2024

.. the configureConnectionFactory callback in the AddRabbitMq, and
AddKeyedRabbitMQ extension methods.

Fixes #2221 .

Microsoft Reviewers: Open in CodeFlow

.. the `configureConnectionFactory` callback in the `AddRabbitMq`, and
`AddKeyedRabbitMQ` extension methods.

Fixes dotnet#2221 .
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Feb 27, 2024
@radical radical marked this pull request as ready for review February 27, 2024 20:38
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@radical radical merged commit dc35d20 into dotnet:main Feb 27, 2024
8 checks passed
@radical radical deleted the rmq-callback-fix branch February 27, 2024 21:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ extension method hides the async configuration possibilities for the client
2 participants