Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RBAC for Azure AI Search #2494

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Use RBAC for Azure AI Search #2494

merged 8 commits into from
Feb 29, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Feb 28, 2024

Fixes #2444

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 28, 2024
src/Aspire.Hosting.Azure/Bicep/search.bicep Outdated Show resolved Hide resolved
src/Aspire.Hosting.Azure/Bicep/search.bicep Outdated Show resolved Hide resolved
src/Aspire.Hosting.Azure/Bicep/search.bicep Outdated Show resolved Hide resolved
src/Aspire.Hosting.Azure/Bicep/search.bicep Outdated Show resolved Hide resolved
@sebastienros
Copy link
Member Author

Also added a missing unit test for the bicep file.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is super nice!

@sebastienros sebastienros merged commit c67d3c4 into main Feb 29, 2024
8 checks passed
@sebastienros sebastienros deleted the sebros/identity branch February 29, 2024 00:37
radical pushed a commit to radical/aspire that referenced this pull request Feb 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AI Search should use managed identity by default
2 participants