Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add a xunit.runner.json to get [Long Running Test] message #2501

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

radical
Copy link
Member

@radical radical commented Feb 28, 2024

This will cause a message like:
[xUnit.net 00:03:54.91] Aspire.EndToEnd.Tests: [Long Running Test] 'Aspire.EndToEnd.Tests.IntegrationServicesTests.VerifyComponentWorks(resourceName: sqlserver)', Elapsed: ...
.. to be printed whenever a test runs over 2 minutes. This will help in debugging tests that might take too long to run, and crash or timeout on CI with no other information.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Feb 28, 2024
@radical radical changed the title [tests] add a xunit.runner.json to get long-running tests message [tests] add a xunit.runner.json to get [Long Running Test] message Feb 28, 2024
@radical radical marked this pull request as ready for review February 28, 2024 06:03
@danmoseley danmoseley closed this Feb 28, 2024
@danmoseley danmoseley reopened this Feb 28, 2024
@danmoseley danmoseley merged commit 02b5a47 into dotnet:main Feb 28, 2024
9 checks passed
@radical radical deleted the tests-long-running branch February 28, 2024 19:05
@joperezr
Copy link
Member

Awesome, thanks @radical!

@danmoseley
Copy link
Member

Anything else interesting in the xunit configs of our other repos that we should copy?

@radical
Copy link
Member Author

radical commented Feb 28, 2024

Anything else interesting in the xunit configs of our other repos that we should copy?

diagnosticMessages can be useful, and we can have turned on for CI. I'm using it in my helix PR where it is pretty useful as we have a test fixture doing a bunch of work that can fail.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants