Rename the annotations #2523
Merged
Rename the annotations #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reamed CustomResourceAnnotation to ResourceUpdatesAnnotation, and CustomResourceLogger to ResourceLoggerAnnotattion. Make it possible to have multiple subscribers to resource updates.
dotnet-issue-labeler
bot
added
the
area-app-model
eerhardt
reviewed
Feb 28, 2024
| @@ -30,14 +30,58 @@ public sealed class CustomResourceAnnotation(Func<CustomResourceSnapshot> initia | |||
| /// Updates the snapshot of the <see cref="CustomResourceSnapshot"/> for a resource. | |||
| /// </summary> | |||
| /// <param name="state">The new <see cref="CustomResourceSnapshot"/>.</param> | |||
| public async Task UpdateStateAsync(CustomResourceSnapshot state) | |||
| public Task UpdateStateAsync(CustomResourceSnapshot state) | |||
There was a problem hiding this comment.
Are we leaving this as "Async" in case we want to do something async in the future?
eerhardt
approved these changes
Feb 28, 2024
ReubenBond
approved these changes
Feb 28, 2024
ReubenBond
reviewed
Feb 28, 2024
mitchdenny
approved these changes
Feb 28, 2024
|
Looks good. Thanks for the rename :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow