Improve logging for flaky OTLP integration test #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
davidfowl,
drewnoakes,
tlmii,
adamint and
kvenkatrajan
|
Same failure |
|
Hmm, it's not a startup race then. Will need to see server logs to figure out what is going on. |
JamesNK
force-pushed
the
jamesnk/flaky-grpc-test
branch
from
030fa2f
to
7662647
Compare
JamesNK
changed the title
|
This doesn't fix the problem, but it improves logging required to fix it. Some please review so future errors have more detail. |
tlmii
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2536
Unfortunately, the build was canceled and removed logs. I couldn't access the output logs to see the exact reason, but I'm guessing the problem is the server wasn't completely ready. I've added a couple of retries, and improved logging.
Microsoft Reviewers: Open in CodeFlow