Testing: move DistributedApplicationBuilder into base test harness #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
BrennanConroy
approved these changes
Mar 4, 2024
ReubenBond
force-pushed
the
rebond/testing/robustness
branch
from
e446dd3
to
f1e7e76
Compare
ReubenBond
force-pushed
the
rebond/testing/robustness
branch
from
f1e7e76
to
915d4af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves logic to get the app builder from
DistributedApplicationTestingBuilderinto the coreDistributedApplicationTestingHarness<TEntryPoint>so that the lifecycle logic is a little more centralized and the control flow is a little clearer. More importantly, it fixes a deadlock introduced while trying make the tests run in CI.Microsoft Reviewers: Open in CodeFlow