Use InputReference in more places #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model the Password inputs on Containers and the Value input on Parameters as an InputReference and use their ValueExpressions instead of hard-coding the strings.
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
reviewed
Mar 5, 2024
| @@ -36,7 +36,7 @@ public static IResourceBuilder<MySqlServerResource> AddMySql(this IDistributedAp | |||
| { | |||
| if (context.ExecutionContext.IsPublishMode) | |||
| { | |||
| context.EnvironmentVariables.Add(PasswordEnvVarName, $"{{{resource.Name}.inputs.password}}"); | |||
| context.EnvironmentVariables.Add(PasswordEnvVarName, resource.PasswordInput.ValueExpression); | |||
There was a problem hiding this comment.
Can we get rid of this if statement and stash the input reference directly in the env variable?
Suggested change
| context.EnvironmentVariables.Add(PasswordEnvVarName, resource.PasswordInput.ValueExpression); | |
| context.EnvironmentVariables[PasswordEnvVarName] = resource.PasswordInput; |
There was a problem hiding this comment.
I can't get rid of the if statement unless InputReference implements IValueProvider. Right now we don't actually have the value (i.e. the password) stored on the InputAnnotation.
I'll see if I can make this change in the next PR.
davidfowl
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model the Password inputs on Containers and the Value input on Parameters as an InputReference and use their ValueExpressions instead of hard-coding the strings.
Microsoft Reviewers: Open in CodeFlow