Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using own PrimaryEndpointName #2657

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Using own PrimaryEndpointName #2657

merged 1 commit into from
Mar 6, 2024

Conversation

MatsM16
Copy link
Contributor

@MatsM16 MatsM16 commented Mar 5, 2024 •
edited by dotnet-policy-service bot
Loading

Some builder extensions reference MySqlServerResource.PrimaryEndpointName instead of their own.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 5, 2024
davidfowl
davidfowl approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing!

@MatsM16
Copy link
Contributor Author

MatsM16 commented Mar 5, 2024 •
edited
Loading

I'm kinda new at contributing to projects like this.
Is splitting these small changes into multiple prs annoying or wanted?
#2657 #2656 #2655

@davidfowl
Copy link
Member

Is splitting these small changes into multiple prs annoying or wanted?

wanted.

@davidfowl davidfowl merged commit 1847177 into dotnet:main Mar 6, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatsM16 @davidfowl