Remove duplicate lin in OpenAI manifest #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
approved these changes
Mar 6, 2024
davidfowl
reviewed
Mar 6, 2024
| @@ -36,12 +36,12 @@ | |||
| "http": { | |||
| "scheme": "http", | |||
| "protocol": "tcp", | |||
| "transport": "http" | |||
| "transport": "tcp" | |||
There was a problem hiding this comment.
Currently debugging, behavior seemed random as I had to delete the file to get this change applied, and it seems it should not be tcp.
There was a problem hiding this comment.
This is a regression not caused by your PR
There was a problem hiding this comment.
I see the change and the default value. Still can't explain why it didn't get updated when the file existed, or why the other file got a duplicated line until the file was deleted. I switched to a "dev drive", hope this is not a bug.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was auto-generated, but this duplicated line would only disappear if the file was deleted before. It got added but also fixed by running
dotnet run -- --publisher manifest --output-path aspire-manifest.jsonMicrosoft Reviewers: Open in CodeFlow