Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InputAnnotation #2684

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Refactor InputAnnotation #2684

merged 3 commits into from
Mar 7, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 6, 2024

  • Implement IValueProvider
  • Cache the Value on the object
  • Remove "Type" because all inputs are strings
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 6, 2024
- Implement IValueProvider
- Cache the Value on the object
- Remove "Type" because all inputs are strings
- Cache Parameter values once they've been retrieved
@eerhardt eerhardt enabled auto-merge (squash) March 6, 2024 23:26
@eerhardt eerhardt merged commit d09c9ff into dotnet:main Mar 7, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants