-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency from OpenTelemetry.Instrumentation.StackExchangeRedis #3104
Conversation
8d76b25
to
be59ecc
Compare
Since the |
....StackExchange.Redis.DistributedCaching/Aspire.StackExchange.Redis.DistributedCaching.csproj
Outdated
Show resolved
Hide resolved
Tests are broken by the change at Update: |
src/Components/Aspire.StackExchange.Redis/Aspire.StackExchange.Redis.csproj
Outdated
Show resolved
Hide resolved
src/Components/Aspire.StackExchange.Redis/Aspire.StackExchange.Redis.csproj
Show resolved
Hide resolved
git fetch --tags | ||
git checkout tags/Instrumentation.SqlClient-1.7.0-beta.1 | ||
git checkout tags/Instrumentation.StackExchangeRedis-1.0.0-rc9.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your thoughts on putting these versions in? As a way to document which version we are currently on? How do we plan on keeping it up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to show which versions are used right now. When there is a new release this has to be updated. Otherwise there is no way to know which is currently used and if work needs to be done. Also the way the otel repos is done each lib is release individually which doesn't help.
/backport to release/8.0-preview5 |
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8442856355 |
@sebastienros backporting to release/8.0-preview5 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Remove dependency from OpenTelemetry.Instrumentation.StackExchangeRedis
Using index info to reconstruct a base tree...
M Directory.Packages.props
M src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj
M src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/Aspire.Microsoft.EntityFrameworkCore.SqlServer.csproj
M src/Vendoring/.editorconfig
M src/Vendoring/README.md
Falling back to patching base and 3-way merge...
Auto-merging src/Vendoring/README.md
CONFLICT (content): Merge conflict in src/Vendoring/README.md
Auto-merging src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/Aspire.Microsoft.EntityFrameworkCore.SqlServer.csproj
Auto-merging src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj
Auto-merging Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove dependency from OpenTelemetry.Instrumentation.StackExchangeRedis
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@sebastienros an error occurred while backporting to release/8.0-preview5, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Microsoft Reviewers: Open in CodeFlow