-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packages to not go stable #3116
Conversation
Why wouldn't we use |
Oh, I wasn't aware of the property's existence 😋. I'm assuming this would just work if that is set with the changes I have here, but I'll double-check. |
Agreed. I guess I was mostly commenting on the PR description above in the top post. For the libraries we don't want to go stable, we should just need to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR description should be updated to reference this property. |
Sorry this took a while, I have just validated that the property indeed works with these changes and packages would remain unstable. |
Updated. |
@joperezr - was this supposed to be backported to release/8.0? I don't see the change in that branch |
You are correct, fixing that now. |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8695610684 |
Fixes #2541
cc: @eerhardt
With these changes, now individual projects can decide to stay marked as preview even when the rest of the repo is producing stable packages. Once we branch for GA, We will update
StabilizePackageVersion
and set it totrue
meaning that the repo will start producing stable packages. That said, individual projects will be able to stay in prerelease by adding the following property in their .csproj:This model is the same as the one used by dotnet/runtime repo.
Microsoft Reviewers: Open in CodeFlow