Stop the apphost from running if the application url is http and ASPIRE_ALLOW_UNSECURED_TRANSPORT is not set #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
reviewed
Mar 26, 2024
eerhardt
reviewed
Mar 26, 2024
|
Are there any tests that can be written for this new functionality? |
eerhardt
reviewed
Mar 26, 2024
davidfowl
reviewed
Mar 26, 2024
eerhardt
reviewed
Mar 26, 2024
eerhardt
reviewed
Mar 26, 2024
drewnoakes
reviewed
Mar 26, 2024
src/Aspire.Hosting/Dashboard/DashboardAuthenticationOptionsValidator.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Mar 26, 2024
src/Aspire.Hosting/Dashboard/DashboardAuthenticationOptionsValidator.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Mar 26, 2024
src/Aspire.Hosting/Dashboard/DashboardAuthenticationOptionsValidator.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Mar 26, 2024
drewnoakes
reviewed
Mar 26, 2024
…ributedApplicationOptions.DisableDashboard to do the right thing in terms of validation.
davidfowl
reviewed
Mar 27, 2024
eerhardt
reviewed
Mar 27, 2024
eerhardt
reviewed
Mar 27, 2024
Co-authored-by: Eric Erhardt <[email protected]>
davidfowl
reviewed
Mar 27, 2024
davidfowl
changed the title
davidfowl
reviewed
Mar 28, 2024
davidfowl
approved these changes
Mar 28, 2024
|
/backport to release/8.0-preview5 |
|
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8460970955 |
|
@mitchdenny backporting to release/8.0-preview5 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Minimal change to kick start the branch.
Using index info to reconstruct a base tree...
M playground/TestShop/AppHost/Properties/launchSettings.json
Falling back to patching base and 3-way merge...
Auto-merging playground/TestShop/AppHost/Properties/launchSettings.json
No changes -- Patch already applied.
Applying: WIP.
Applying: WIP
Using index info to reconstruct a base tree...
M playground/TestShop/AppHost/Properties/launchSettings.json
M src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
M src/Aspire.Hosting/DistributedApplicationBuilder.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Hosting/DistributedApplicationBuilder.cs
Auto-merging src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
CONFLICT (content): Merge conflict in src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
Auto-merging playground/TestShop/AppHost/Properties/launchSettings.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 WIP
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@mitchdenny an error occurred while backporting to release/8.0-preview5, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
mitchdenny
added a commit
that referenced
this pull request
Mar 28, 2024
…RE_ALLOW_UNSECURED_TRANSPORT is not set (#3177)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making use of the options validation APIs to blow up if the URL is http and the allow insecure environment is not set. The environment variable that binds to the option is:
Microsoft Reviewers: Open in CodeFlow