Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] EndToEnd tests: use a simple lock for writing to output stringBuilder #3205

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

radical
Copy link
Member

@radical radical commented Mar 27, 2024

.. to avoid failures like:

[xUnit.net 00:01:13.85]     Aspire.EndToEnd.Tests.IntegrationServicesTests.VerifyComponentWorks(resourceName: mongodb) [FAIL]
[xUnit.net 00:01:13.85]       System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than or equal to the size of the collection. (Parameter 'chunkLength')
[xUnit.net 00:01:13.85]       Stack Trace:
[xUnit.net 00:01:13.85]            at System.Text.StringBuilder.ToString()
[xUnit.net 00:01:13.85]            at System.Runtime.CompilerServices.DefaultInterpolatedStringHandler.AppendFormatted[T](T value)
[xUnit.net 00:01:13.85]         /_/tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs(178,0): at Aspire.EndToEnd.Tests.IntegrationServicesFixture.InitializeAsync()
Microsoft Reviewers: Open in CodeFlow

…gBuilder

.. to avoid failures like:
```
[xUnit.net 00:01:13.85]     Aspire.EndToEnd.Tests.IntegrationServicesTests.VerifyComponentWorks(resourceName: mongodb) [FAIL]
[xUnit.net 00:01:13.85]       System.ArgumentOutOfRangeException : Index was out of range. Must be non-negative and less than or equal to the size of the collection. (Parameter 'chunkLength')
[xUnit.net 00:01:13.85]       Stack Trace:
[xUnit.net 00:01:13.85]            at System.Text.StringBuilder.ToString()
[xUnit.net 00:01:13.85]            at System.Runtime.CompilerServices.DefaultInterpolatedStringHandler.AppendFormatted[T](T value)
[xUnit.net 00:01:13.85]         /_/tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs(178,0): at Aspire.EndToEnd.Tests.IntegrationServicesFixture.InitializeAsync()
```
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 27, 2024
@radical radical merged commit f684087 into dotnet:main Mar 27, 2024
8 checks passed
@radical radical deleted the output-lock-tests branch March 27, 2024 03:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants