Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Hosting.Azure packages after splitting #3227

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 27, 2024

  • Remove unnecessary dependencies from Hosting.Azure to PostgreSQL, Redis, and SqlServer.
  • Rename Aspire.Hosting.Azure.PosgresSQL to use consistent case with the rest of the libraries.

Doing this before we ship preview5, so it doesn't cause problems down the line. Removing the dependencies could be considered a breaking change. And fixing the casing might not be possible once we push to nuget.org.

Microsoft Reviewers: Open in CodeFlow

- remove unnecessary dependencies from Hosting.Azure to PostgreSQL, Redis, and SqlServer.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 27, 2024
@eerhardt eerhardt merged commit 25a507f into dotnet:main Mar 28, 2024
8 checks passed
@eerhardt eerhardt deleted the RemoveUnnecessaryDependencies branch March 28, 2024 00:45
@eerhardt
Copy link
Member Author

/backport to release/8.0-preview.5

Copy link
Contributor

Started backporting to release/8.0-preview.5: https://github.com/dotnet/aspire/actions/runs/8460672665

Copy link
Contributor

@eerhardt an error occurred while backporting to release/8.0-preview.5, please check the run log for details!

Error: The specified backport target branch release/8.0-preview.5 wasn't found in the repo.

@eerhardt
Copy link
Member Author

/backport to release/8.0-preview5

Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8460681429

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants