-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry on YamlException when loading Kubernetes client configuration #3229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment
Done: // Handle exceptions caused by races between writing and reading the configuration file.
// If the file is loaded while it is still being written, this can result in a YamlException being thrown.
ShouldHandle = new PredicateBuilder().Handle<KubeConfigException>().Handle<YamlException>(), |
/backport to release/8.0-preview.5 |
Started backporting to release/8.0-preview.5: https://github.com/dotnet/aspire/actions/runs/8458282329 |
@ReubenBond an error occurred while backporting to release/8.0-preview.5, please check the run log for details! Error: @ReubenBond is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=ReubenBond |
/backport to release/8.0-preview.5 |
@joperezr why does the bot not like @ReubenBond ? |
Started backporting to release/8.0-preview.5: https://github.com/dotnet/aspire/actions/runs/8458309383 |
@ReubenBond an error occurred while backporting to release/8.0-preview.5, please check the run log for details! Error: The specified backport target branch release/8.0-preview.5 wasn't found in the repo. |
/backport to release/8.0-preview5 |
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8458401139 |
I encountered this while running an integration test:
My assumption is that this is caused by a race between writing and ready the Kubernetes client configuration file. By handling the resulting
YamlException
, we allow the process to be retried.Microsoft Reviewers: Open in CodeFlow