Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config value to use unsecured instead of insecure #3233

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 27, 2024

We're using unsecured everywhere else. And this setting defaults the frontend and OTLP endpoint auth modes to unsecured. Seems like it should be consistent.

If merged, I'll backport to P5.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesNK JamesNK enabled auto-merge (squash) March 28, 2024 01:07
@JamesNK JamesNK merged commit 69b461e into main Mar 28, 2024
8 checks passed
@JamesNK JamesNK deleted the jamesnk/rename-allow-anonymous branch March 28, 2024 01:36
@JamesNK
Copy link
Member Author

JamesNK commented Mar 28, 2024

/backport to release/8.0-preview5

Copy link
Contributor

Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8461709883

@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants