Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeyVault parent explicit. #3276

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Mar 29, 2024

Minor change to make keyvault parent more explicit in the PublishAsAzureKeyvaultFlexibleServerInternal method.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 29, 2024
@mitchdenny mitchdenny self-assigned this Mar 29, 2024
@mitchdenny mitchdenny added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 29, 2024
@mitchdenny mitchdenny added this to the preview 5 (Apr) milestone Mar 29, 2024
@davidfowl
Copy link
Member

Is this the only one?

@mitchdenny
Copy link
Member Author

Is this the only one?

Cosmos is another one. Updated in this PR too.

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl removed the area-integrations Issues pertaining to Aspire Integrations packages label Mar 30, 2024
@davidfowl
Copy link
Member

@mitchdenny I don't think this is preview 5

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Member Author

Its not blocking.

@mitchdenny
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny enabled auto-merge (squash) March 31, 2024 20:37
@mitchdenny mitchdenny merged commit 9c4533e into main Mar 31, 2024
8 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/make-postgres-kv-secret-explicit branch March 31, 2024 21:36
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants