-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make KeyVault parent explicit. #3276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-integrations
Issues pertaining to Aspire Integrations packages
label
Mar 29, 2024
mitchdenny
added
the
area-app-model
Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
label
Mar 29, 2024
Is this the only one? |
Cosmos is another one. Updated in this PR too. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
davidfowl
approved these changes
Mar 30, 2024
davidfowl
removed
the
area-integrations
Issues pertaining to Aspire Integrations packages
label
Mar 30, 2024
@mitchdenny I don't think this is preview 5 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Its not blocking. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to make keyvault parent more explicit in the PublishAsAzureKeyvaultFlexibleServerInternal method.
Microsoft Reviewers: Open in CodeFlow