Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional project template string #3286

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Mar 29, 2024

This file gets created every time I build main right now. I think it was missed in #3219 but I'm not entirely sure how that all works.

@DamianEdwards @joperezr FYI, in case you know what's going on here.

Microsoft Reviewers: Open in CodeFlow

@DamianEdwards
Copy link
Member

DamianEdwards commented Mar 29, 2024

Yep, I forgot to build the template package. We should have a test so that CI fails if any files are add/changed when templates are built. We should probably backport this?

@tlmii tlmii enabled auto-merge (squash) March 29, 2024 18:51
@tlmii
Copy link
Member Author

tlmii commented Mar 29, 2024

@joperezr Guessing I can backport this to Preview 6 with no issue. If we have to do another P5 during QB mode this is low-risk to sneak in but I'm guessing probably not worth it on its own?

@tlmii tlmii merged commit 739bb2a into dotnet:main Mar 29, 2024
8 checks passed
@tlmii tlmii deleted the dev/update-aspire-starter-config branch March 29, 2024 19:14
@tlmii
Copy link
Member Author

tlmii commented Mar 29, 2024

/backport to release/8.0

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8484682594

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants