Ensure logAnalyticsWorkspaceId parameter is present in Aspire manifest. #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
davidfowl
reviewed
Mar 30, 2024
|
@joperezr we will want to back port this one to preview 5. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidfowl
approved these changes
Mar 30, 2024
davidfowl
reviewed
Mar 30, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/backport to release/8.0-preview5 |
|
Started backporting to release/8.0-preview5: https://github.com/dotnet/aspire/actions/runs/8494527436 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3133 and #3273
To fix this I've added an argument to the
AddAzureApplicationInsights(...)extension methods that allows it to take anIResourceBuilder<AzureLogAnalyticsWorkspaceResource>and uses a reference to that resource to populate thelogAnalyticsWorkspaceIdparameter in the manifest.If this value is not passed in we still ensure that the parameter is in the manifest so that it can be supplied by AZD.
Microsoft Reviewers: Open in CodeFlow