[release/8.0] Remove obsolete APIs.

[github-actions]

Backport of #3329 to release/8.0

/cc @mitchdenny

Customer Impact

Only removing APIs that were already marked with obsolete. Many have been marked obsolete since P3/P4. There are some obsolete APIs remaining into GA but they are internal related to DCP.

Testing

These APIs weren't used any more in our test cases/playgrounds anyway after we obsoleted them.

Risk

Low. Some customers may have used these APIs but they should have been getting obsolete warnings for a while.

Microsoft Reviewers: Open in CodeFlow

[eerhardt]

@mitchdenny - there is still these Obsolete attributes present in the code:

aspire/src/Aspire.Hosting/Dcp/Model/Executable.cs

Lines 116 to 118 in 81d1db1

	[Obsolete] public const string CSharpProjectPathAnnotation = "csharp-project-path";
	[Obsolete] public const string CSharpLaunchProfileAnnotation = "csharp-launch-profile";
	[Obsolete] public const string CSharpDisableLaunchProfileAnnotation = "csharp-disable-launch-profile";

Along with this suppression and TODO:

aspire/src/Aspire.Hosting/Dcp/ApplicationExecutor.cs

Lines 1002 to 1014 in 81d1db1

	#pragma warning disable CS0612 // These annotations are obsolete; remove in Aspire Preview 6
	annotationHolder.Annotate(Executable.CSharpProjectPathAnnotation, projectMetadata.ProjectPath);
	// ExcludeLaunchProfileAnnotation takes precedence over LaunchProfileAnnotation.
	if (project.TryGetLastAnnotation<ExcludeLaunchProfileAnnotation>(out _))
	{
	annotationHolder.Annotate(Executable.CSharpDisableLaunchProfileAnnotation, "true");
	}
	else if (project.TryGetLastAnnotation<LaunchProfileAnnotation>(out var lpa))
	{
	annotationHolder.Annotate(Executable.CSharpLaunchProfileAnnotation, lpa.LaunchProfileName);
	}
	#pragma warning restore CS0612

What is the plan for those?

cc @karolz-ms

[karolz-ms]

@eerhardt the plan is to remove these post-GA. Even P5 is relying on these, and given all the moving parts (Aspire.Hosting, IDEs, DCP) I would be hesitant to touch these earlier than that.

Do you want me to open a tracking issue?

[eerhardt]

Do you want me to open a tracking issue?

Yes please.

It might make sense to update this comment since it says "remove in Aspire Preview 6".

[karolz-ms]

@eerhardt done and done (the comment part via #3294)