Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AspNetCore.HealthChecks.* to latest versions #3338

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 2, 2024

The new versions have specific builds for the .NETCoreApp TFM, which fixes some dependency issues like not having the 8.0.0 version of Microsoft.Bcl.AsyncInterfaces. See Xabaril/AspNetCore.Diagnostics.HealthChecks#2180.

Microsoft Reviewers: Open in CodeFlow

The new versions have specific builds for the .NETCoreApp TFM, which fixes some dependency issues like not having the 8.0.0 version of Microsoft.Bcl.AsyncInterfaces. See Xabaril/AspNetCore.Diagnostics.HealthChecks#2180.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 2, 2024
@radical
Copy link
Member

radical commented Apr 2, 2024

Failing with Unable to find package AspNetCore.HealthChecks.Redis with version (>= 8.0.1)

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming build is green, change LGTM

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sebastienros
Copy link
Member

I ran the pipeline to add the packages in the feed

@eerhardt eerhardt enabled auto-merge (squash) April 2, 2024 18:59
@eerhardt eerhardt merged commit c628d59 into dotnet:main Apr 2, 2024
8 checks passed
@eerhardt eerhardt deleted the UpdateHealthChecks branch April 2, 2024 23:17
@eerhardt
Copy link
Member Author

eerhardt commented Apr 2, 2024

/backport to release/8.0

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8530724847

radical pushed a commit to radical/aspire that referenced this pull request Apr 3, 2024
The new versions have specific builds for the .NETCoreApp TFM, which fixes some dependency issues like not having the 8.0.0 version of Microsoft.Bcl.AsyncInterfaces. See Xabaril/AspNetCore.Diagnostics.HealthChecks#2180.
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants