[release/8.0] Tweak Bicep string name. #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
joperezr
added
Servicing-consider
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3331 to release/8.0
/cc @mitchdenny
Customer Impact
The
AddBicepTemplateStringextension method takes a string of Bicep text and as part of generating the manifest for use by AZD writes the string out to disk into a file called[resourcename].bicep. This is inconsistent with the other Bicep files we generate via CDK. So for the sake of consistency we are changing this to[resourcename].module.bicep.Testing
We have unit test coverage for this and the tests were updated. Also tested manually in our playground projects.
Risk
Low. This is a cosmetic change. The path to the file is always defined by the manifest anyway (regardless of what the name is).
Microsoft Reviewers: Open in CodeFlow