[release/8.0] [tests] EndToEnd - add test scenarios (#3113) #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test scenarios allow defining different groupings for tests to be run. This is useful for CI to run the tests in separate helix items.
```csharp
TestResourceNames resourcesToInclude = TestScenario switch
{
"oracle" => TestResourceNames.oracledatabase,
"cosmos" => TestResourceNames.cosmos,
"scenario0" => TestResourceNames.kafka
| TestResourceNames.mongodb
| TestResourceNames.rabbitmq
| TestResourceNames.redis
| TestResourceNames.postgres
| TestResourceNames.efnpgsql
| TestResourceNames.mysql
| TestResourceNames.efmysql
| TestResourceNames.sqlserver,
"" or null => TestResourceNames.All,
_ => throw new ArgumentException($"Unknown test scenario '{TestScenario}'")
};
```
Once `eforacle` is added it can run with the `oracle` scenario.
The default is to run all the tests.
Also:
- Enable `cosmos` E2E tests on helix
- make `TestResourceNames` into a `[Flag]` enum so multiple can be expressed at the same time.
- And support dumping docker container logs for resources where the resource name does not match the container name prefix. For example `efnpgsql` vs `postgres`.
dotnet-issue-labeler
bot
added
the
area-integrations
|
Test failure is unrelated - #3380 . |
Don't merge on RED though as this was a non-helix test failure, thus the helix tests never ran. |
radical
approved these changes
Apr 4, 2024
eerhardt
approved these changes
Apr 4, 2024
Comment on lines
+278
to
+280
| public async Task DumpComponentLogsAsync(TestResourceNames resource, ITestOutputHelper? testOutputArg = null) | ||
| { | ||
| string component = resource switch |
There was a problem hiding this comment.
(not for this PR, but we can fix it in main) -
This is kind of weird now that TestResourceNames is a flags enum. If you pass in a value with multiple resources set, it will throw with "unknown resource: {resource}". Maybe the error message could be better saying only single resource names are supported?
|
@joperezr could you please merge this? I don't have permissions for it. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3113 into release/8.0
Original Description:
Test scenarios allow defining different groupings for tests to be run. This is useful for CI to run the tests in separate helix items.
Once
eforacleis added it can run with theoraclescenario.The default is to run all the tests.
Also:
cosmosE2E tests on helixTestResourceNamesinto a[Flag]enum so multiple can be expressed at the same time.efnpgsqlvspostgres.Microsoft Reviewers: Open in CodeFlow