Explicitly specify grpc OTLP protocol with env var #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
drewnoakes,
BrennanConroy,
adamint and
kvenkatrajan
drewnoakes
approved these changes
Apr 4, 2024
tlmii
approved these changes
Apr 4, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8562623518 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3166
Most SDK's OTLP exporters default to gRPC but we should be explicit in case there are exporters that prefer another protocol. We want them to use grpc.
I think Python is an example of a protocol that defaults to Protobuf/JSON over HTTP. Customer report of trouble getting Aspire working because they used HTTP.
Microsoft Reviewers: Open in CodeFlow