Use ConfigureAwait(false) when enumerating IAsyncEnumerable #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
approved these changes
Apr 5, 2024
davidfowl
reviewed
Apr 6, 2024
| @@ -47,7 +47,7 @@ internal async Task SetLogSourceAsync(IAsyncEnumerable<IReadOnlyList<ResourceLog | |||
| var cancellationToken = await _cancellationSeries.NextAsync(); | |||
| var logParser = new LogParser(); | |||
|
|
|||
| await foreach (var batch in batches.WithCancellation(cancellationToken)) | |||
| await foreach (var batch in batches.WithCancellation(cancellationToken).ConfigureAwait(false)) | |||
There was a problem hiding this comment.
This is a bug @ReubenBond, see #3459
davidfowl
reviewed
Apr 6, 2024
| @@ -105,7 +105,7 @@ async Task TrackResourceSnapshotsAsync() | |||
|
|
|||
| _resourceSubscriptionTask = Task.Run(async () => | |||
| { | |||
| await foreach (var changes in subscription.WithCancellation(_resourceSubscriptionCancellation.Token)) | |||
| await foreach (var changes in subscription.WithCancellation(_resourceSubscriptionCancellation.Token).ConfigureAwait(false)) | |||
There was a problem hiding this comment.
This one isn't a problem since Task.Run doesn't capture the sync context.
davidfowl
reviewed
Apr 6, 2024
| @@ -39,7 +39,7 @@ public ResourceOutgoingPeerResolver(IDashboardClient resourceService) | |||
| await RaisePeerChangesAsync().ConfigureAwait(false); | |||
| } | |||
|
|
|||
| await foreach (var changes in subscription.WithCancellation(_watchContainersTokenSource.Token)) | |||
| await foreach (var changes in subscription.WithCancellation(_watchContainersTokenSource.Token).ConfigureAwait(false)) | |||
There was a problem hiding this comment.
These changes are problematic in UI code generally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR qualms the complaints the
EnsureWarningsAreEmittedWhenProjectReferencingLibrariestests when I run it locally, and it's in-line with our existing practice of using.ConfigureAwait(false)in Aspire.Microsoft Reviewers: Open in CodeFlow