[release/8.0] Added ability to resolve target port #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added ability to resolve target port - Change how we process and expose target ports. This change makes it possible to avoid using any internals of DCP to access and resolve target ports from any resource. - More launch profile processing to the project resource defaults. - Remove logic in the manifest writing that wrote a special env variable. This should just work now like everything else. - Exposed TargetPort and Exists on EndpointReference. - Use this new target property with dapr. - Added a ReferenceExpressionBuilder which makes it possible to dynamically build a ReferenceExpression. - Endpoints and env are evaulated earlier now so change remove tests that add default launch profile on real projects without allocating those endpoints. * Remove more uses of TestProgram * Fix tests
This allows us to not leak "DCP" into the public API and keeps DCP-isms contained in the DCP code.
* Do not set TargetPort to Port when IsProxied is true * Move TargetPort check to ApplicationExecutor * Apply port selection logic to manifest publishing (cherry picked from commit 09f5ae9) * Update src/Aspire.Hosting/Dcp/ApplicationExecutor.cs Co-authored-by: Eric Erhardt <[email protected]> --------- Co-authored-by: Eric Erhardt <[email protected]>
eerhardt
requested review from
davidfowl,
ReubenBond,
mitchdenny,
joperezr and
karolz-ms
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
davidfowl
approved these changes
Apr 5, 2024
ReubenBond
approved these changes
Apr 6, 2024
danmoseley
added
Servicing-approved
|
Approved in chat |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3305 #3371 and #3372 to release/8.0
/cc @davidfowl
Customer Impact
Dapr was broken in preview5 because of the endpoint / port refactoring. This changes how we process and expose target ports to correct that break. It refactors APIs that can't be changed once we ship 8.0, so it falls under "API fit and finish".
Testing
New unit tests added.
LocalOnly Node app test now passes locally
Manual testing
Risk
Medium - the original change has already broken Node apps
Microsoft Reviewers: Open in CodeFlow