Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name collision warning. #3474

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Name collision warning. #3474

merged 2 commits into from
Apr 9, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Apr 8, 2024

This pull request includes a small change to the src/Aspire.Hosting.Azure.AppConfiguration/README.md file. The change adds a note advising users to consider setting the name of their resource to something other than "config" or "appconfig" to avoid possible name collisions.

Addresses #2954

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 8, 2024
@mitchdenny
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley danmoseley merged commit c876e84 into main Apr 9, 2024
8 checks passed
@danmoseley danmoseley deleted the mitchdenny/name-collision-warning branch April 9, 2024 01:57
@danmoseley
Copy link
Member

Open to backport if you like as it's only readme and helps supportability

@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants