[release/8.0] Fully qualify container images #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Podman doesn't default to the docker.io registry when no registry is listed. Fully qualify the container image and registry to avoid any issues with assuming a reference. Fix #3423
- Be consistent with all hosting extensions and split the ImageTags into a separate static class - Fix tests
dotnet-issue-labeler
bot
added
the
area-app-model
mitchdenny
approved these changes
Apr 9, 2024
danmoseley
added
Servicing-approved
eerhardt
approved these changes
Apr 9, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3500 to release/8.0
/cc @davidfowl @eerhardt
Customer Impact
Our container images aren't working with Podman because Podman doesn't implicitly use
docker.iowhen no registry is specified.Testing
Automated tests updated.
Manually tested with Podman on Ubuntu. playground/TestShop works locally.
Risk
Pretty low. We are using the same images, just fully qualifying them now.
Regression?
No
Microsoft Reviewers: Open in CodeFlow