Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update ASPIRE002 warning message #3563

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 10, 2024

Backport of #3555 to release/8.0

/cc @eerhardt @martincostello

Customer Impact

We updated the package name from Aspire.Hosting to Aspire.Hosting.AppHost in preview5. We missed updating a warning message in MSBuild. We are using the wrong PackageReference name in our warning message, which is confusing to users.

Testing

Current tests pass. Just a message update.

Risk

Low. This just updates the message.

Regression?

Yes. In Preview5.

Microsoft Reviewers: Open in CodeFlow

Update package reference name from `Aspire.Hosting` to `Aspire.Hosting.AppHost`.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 10, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 10, 2024
@eerhardt eerhardt enabled auto-merge (squash) April 10, 2024 16:34
@eerhardt eerhardt merged commit 33f7b90 into release/8.0 Apr 10, 2024
7 checks passed
@eerhardt eerhardt deleted the backport/pr-3555-to-release/8.0 branch April 10, 2024 17:07
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants