[release/8.0] Flow dashboard logs through the app host's logger #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…waiting for dashboard logs configurable - Disable all dashboard logging by default - Allow config override for default logging categories - Added tests
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
JamesNK
approved these changes
Apr 11, 2024
mitchdenny
approved these changes
Apr 11, 2024
danmoseley
added
Servicing-approved
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3523 to release/8.0
/cc @davidfowl
Customer Impact
If the dashboard fails to launch, there's no way to get the logs other than digging deeply into DCP guts to find logs for it. This is because we don't show the dashboard logs in the dashboard (amongst other things). This change allows users to turn on dashboard logging levels via configuration so we can get better diagnostics when failures occur in the wild.
Testing
Unit tests, manual tests, updated one sample to turn on the logging.
Risk
Low, the code is resilient to failures and will noop if dcp is unhealthy and we're unable to get the logs.
Regression?
No