Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix broken find token image in HTTP #3638

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 12, 2024

Backport of #3635 to release/8.0

/cc @JamesNK

Customer Impact

If a customer is running with http (this will be common when starting the dashboard from docker) then the help image on the login page is broken.

Testing

Manual testing.

Risk

Low. Slightly loosen CSP for http requests.

Regression?

Yes.

@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 12, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 12, 2024
@davidfowl davidfowl merged commit 4ccd14b into release/8.0 Apr 12, 2024
7 checks passed
@davidfowl davidfowl deleted the backport/pr-3635-to-release/8.0 branch April 12, 2024 05:14
@joperezr
Copy link
Member

/backport to release/8.0-preview6

Copy link
Contributor Author

Started backporting to release/8.0-preview6: https://github.com/dotnet/aspire/actions/runs/8664846804

@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants