Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Set correct AutoFocus value for FluentPopover #3663

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 12, 2024

Backport of #3661 to release/8.0

/cc @kvenkatrajan @vnbaaij

Customer Impact

Customer is unable to close ornavigate to other endpoints after an endpoint is displayed in the modal

Testing

Manual on main branch. Validated that the modal closes after clicking on the +1 when its open

Risk

Low

Regression?

Yes

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 12, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 12, 2024
@danmoseley danmoseley enabled auto-merge (squash) April 12, 2024 18:45
@danmoseley
Copy link
Member

Thanks @vnbaaij by the way!

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signoff just = yes it's a faithful port.

@kvenkatrajan kvenkatrajan self-requested a review April 12, 2024 18:46
@kvenkatrajan
Copy link
Member

/backport to release/8.0-preview6

Copy link
Contributor Author

Started backporting to release/8.0-preview6: https://github.com/dotnet/aspire/actions/runs/8667116963

@danmoseley danmoseley merged commit bd6aa61 into release/8.0 Apr 12, 2024
7 checks passed
@danmoseley danmoseley deleted the backport/pr-3661-to-release/8.0 branch April 12, 2024 21:34
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants