Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update OTEL HTTP instrumentation packages to 1.8.1 #3681

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 14, 2024

Customer Impact

Updated packages so URL query is redacted by default. Customers who create Aspire apps should use OTEL packages that are secure by default.

This PR:

  • Update packages used in repo.
  • Update packages used in templates.
  • Pass env var to disable redaction when Aspire is run dev environment. Redaction still happens if Aspire app host is run with non-development environment, or the apps are deployed.

Testing

Manual testing.

Risk

Low

Regression?

No

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 14, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Apr 14, 2024

/backport to release/8.0-preview6

Copy link
Contributor

Started backporting to release/8.0-preview6: https://github.com/dotnet/aspire/actions/runs/8678622227

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 14, 2024
@danmoseley danmoseley enabled auto-merge (squash) April 14, 2024 16:19
@danmoseley danmoseley merged commit f7a503b into release/8.0 Apr 15, 2024
8 checks passed
@danmoseley danmoseley deleted the jamesnk/otel-urlredaction-8.0 branch April 15, 2024 04:51
@eerhardt
Copy link
Member

@JamesNK - did you happen to see #3676 (comment)?

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants