Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Start producing stable packages #3785

Merged
merged 5 commits into from
May 7, 2024

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Apr 17, 2024

As part of our preparation for stabilization, we need to start producing stable packages from this branch. This change will make it so that all packages that are not marked as SuppressFinalPackageVersion will now produce a stable package version. This will also make it so we have CI validation to ensure that packages that are going stable will not get a new dependency bump with a prerelease version.

This change will have implications going forward, which mainly are:

  • Because we are using stable versions, packages from this branch will no longer get published to the dotnet-tools feed, and instead will get a dedicated feed for each build. This means that our installLatestFromREleaseBranch scripts will no longer work for getting latest build, so I'll work with @balachir for new instructions on how to get latest builds for validation.
  • For people trying things out locally, you should be aware that because these are stable versions, it means that these would be saved in your machine's global cache. This means that before you can use newer builds that produce the same version, you'll need to make sure you clean up your cache first by running dotnet nuget locals all -c, in order to prevent the previous build from the cache to get used.

cc: @eerhardt, @davidfowl, @DamianEdwards, @mitchdenny, @ReubenBond.

Microsoft Reviewers: Open in CodeFlow

@joperezr joperezr requested a review from eerhardt April 17, 2024 20:26
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 17, 2024
@joperezr joperezr added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 17, 2024
@joperezr
Copy link
Member Author

Marking as No-Merge for now given the dogfooding implications. We'll merge this a little later.

@joperezr
Copy link
Member Author

joperezr commented May 6, 2024

This is now ready to go, so removing the NoMerge label.

@joperezr joperezr removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 6, 2024
@DamianEdwards
Copy link
Member

DamianEdwards commented May 6, 2024

image

@joperezr joperezr force-pushed the StablePackages branch 2 times, most recently from e5cb50a to 9ddda33 Compare May 7, 2024 03:42
@joperezr
Copy link
Member Author

joperezr commented May 7, 2024

cc @radical if you check my last commit 24a05b8, I had to make a small change given the workload test infrastructure had a bug when testing against stable versions. My change was simple to unblock this PR, but we'll probably need something that actually looks at what the package version for each package should be for main branch.

@joperezr
Copy link
Member Author

joperezr commented May 7, 2024

Merging this in to start preparing for an insertion. I will Address any feedback in a follow up PR.

@joperezr joperezr merged commit 8d4b6d9 into dotnet:release/8.0 May 7, 2024
8 checks passed
@joperezr joperezr deleted the StablePackages branch May 16, 2024 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants