[release/8.0] Service Discovery: make scheme selection more intuitive in un-specified case, add more tests #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ection more intuitive in un-specified case
dotnet-policy-service
bot
added
the
Servicing-consider
joperezr
added
Servicing-approved
RussKie
approved these changes
Apr 19, 2024
|
@ReubenBond or someone, can you sign off |
ReubenBond
approved these changes
Apr 22, 2024
|
@danmoseley done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3837 to release/8.0
/cc @ReubenBond
Customer Impact
When calling
WithReference(Uri), we add an endpoint to the"default"section in configuration. This PR ensures that we always check the default section by default when the user has not explicitly specified an endpoint name.Testing
Additional tests coverage is included.
Risk
Low: this change is backwards-compatible for customers using the existing format (eg, AppHost continues to use the existing format).
Regression?
Yes, since
WithReference(Uri)behavior regressed.Microsoft Reviewers: Open in CodeFlow