[release/8.0] Event Hubs: Update EventProcessorClient component to pull BlobClient from DI (#3293) #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from DI (dotnet#3293) * update sample EH project launchsettings; add blob component for processor * update azurecomponent to expose serviceprovider; update associated components; update processor for DI retrieval of blob client * throw if blobclient cannot be retrieved from DI (this is a breaking change from P5) * fix tests * PR feedback * More PR feedback * Rename BlobClientConnectionName to BlobClientServiceKey. Remove the need to specify a BlobClientServiceKey, and use an unkeyed client if none is provided. * fix tests * fixup formatting --------- Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sebastien Ros <[email protected]>
dotnet-issue-labeler
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
Servicing-consider
eerhardt
changed the title
danmoseley
added
Servicing-approved
joperezr
approved these changes
Apr 26, 2024
|
@mitchdenny do you want to be other sign off? |
mitchdenny
approved these changes
Apr 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3293 to release/8.0
Customer Impact
On the initial PR of Azure EventHubs there was some usability / composability issues that were addressed in a follow-up PR. Even though the EventHubs component will still be in "preview" when Aspire 8.0.0 is GA, getting feedback on this change is important to ensure we have the right API for the EventHubs component. If we don't take this change, we won't be able to get true feedback on the API.
It also makes porting other changes (like the tests in #3919) to reduce conflicts and "drift" between main and release/8.0.
Testing
The unit tests were updated for the new functionality. playground app is updated as well.
Risk
Low. EventHubs will still be in preview when 8.0.0 ships. There is some internal refactoring to the common Azure shared code, but it doesn't change behavior.
Regression?
No
update sample EH project launchsettings; add blob component for processor
update azurecomponent to expose serviceprovider; update associated components; update processor for DI retrieval of blob client
throw if blobclient cannot be retrieved from DI (this is a breaking change from P5)
fix tests
PR feedback
More PR feedback
Rename BlobClientConnectionName to BlobClientServiceKey.
Remove the need to specify a BlobClientServiceKey, and use an unkeyed client if none is provided.
fix tests
fixup formatting
Microsoft Reviewers: Open in CodeFlow