[release/8.0] Rename WithContainerRunArgs to WithContainerRuntimeArgs to reduce potential confusion #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
eerhardt
reviewed
Apr 25, 2024
…ckAnnotation.cs Co-authored-by: Damian Edwards <[email protected]>
Co-authored-by: Damian Edwards <[email protected]>
danegsta
force-pushed
the
danegsta/backportApiRename
branch
from
ec3f7a8
to
fd44a7c
Compare
danegsta
changed the title
danmoseley
added
Servicing-approved
src/Aspire.Hosting/ApplicationModel/ContainerRuntimeArgsCallbackAnnotation.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/ContainerRuntimeArgsCallbackAnnotation.cs
Outdated
Show resolved
Hide resolved
DamianEdwards
requested changes
Apr 25, 2024
dotnet-policy-service
bot
added
the
needs-author-action
|
Doc comments have been updated |
dotnet-policy-service
bot
removed
the
needs-author-action
DamianEdwards
approved these changes
Apr 26, 2024
davidfowl
approved these changes
Apr 26, 2024
Can these be ported to |
eerhardt
added
the
breaking-change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3950 to release/8.0
Customer Impact
Original API name for WithContainerRunArgs was causing user confusion. We received a request to rename in order to clarify that this is for providing arguments to the container host when running a container, not additional commands to run inside the container at startup. This is a breaking change, but this is an advanced API intended to be used only in specific scenarios.
Testing
Aspire unit tests
Risk
Low
Regression
No
Microsoft Reviewers: Open in CodeFlow