[release/8.0] Set an upper bound on RabbitMQ dependency #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 7 has binary breaking changes that cause the Aspire.RabbitMQ.Client component to fail loading with a MissingMethodException. Contributes to dotnet#3956
dotnet-issue-labeler
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Apr 26, 2024
DamianEdwards
approved these changes
Apr 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3972 to release/8.0
Customer Impact
RabbitMQ.Client v7 has many public API breaking changes. So many that our component doesn't even load with the 7.0-alpha releases. Setting a limit on our dependency means that customers will understand they can't use the 7.0 packages with our component.
Testing
Automated tests passing in the repo. I also ran
dotnet pack .\src\Components\Aspire.RabbitMQ.Client\and inspected the resulting nuget package has the right dependency version:Risk
Low. We are depending on the same version. Just limiting to what versions we allow users to move to when using our component.
Regression?
No
Version 7 has binary breaking changes that cause the Aspire.RabbitMQ.Client component to fail loading with a MissingMethodException.
Contributes to #3956
Microsoft Reviewers: Open in CodeFlow