Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add missing translations #4004

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 29, 2024

Backport of #3408 to release/8.0

/cc @JamesNK @adamint

Customer Impact

Some UI elements on structured logs page aren't translated.

Testing

Manual testing on the branch. English translation continues to work:

image

and

image

Risk

Low

Regression?

No

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 29, 2024
@danmoseley danmoseley added this to the GA milestone Apr 29, 2024
@danmoseley
Copy link
Member

@kvenkatrajan @adamint could you review

Somehow the `.Designer.cs` files for `Columns.resx` and `Logs.resx` were inverted. Any change to one of these files would result in compilation errors due to duplicate classes.

This change renames the files so that future regeneration won't hit problems.
@JamesNK
Copy link
Member

JamesNK commented Apr 29, 2024

Seems ok from manual testing. Just tested English.

I remember that this PR had a regression where the Logs and Columns generated code was mixed up for some reason. I also cherry-picked that fix from #3632

@danmoseley
Copy link
Member

Thanks James.

@danmoseley
Copy link
Member

We were missing the translations 😄 .. fixed

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2024
@danmoseley
Copy link
Member

Might be worth someone flipping their locale and exercising the dashboard just to look for any places we eg don't pull from resources.
@balachir do your team use non ENU

@balachir
Copy link

@danmoseley yes we do cover non-ENU configurations as well. @v-sherryfan @v-elenafeng fyi on this incoming fix for 8.0 GA. When verifying this, please test with non-ENU configurations too.

@JamesNK
Copy link
Member

JamesNK commented Apr 29, 2024

I tested on my machine:

image

image

Looks good to me.

@JamesNK
Copy link
Member

JamesNK commented Apr 29, 2024

I raised this in the original issue - #2877 - graph still isn't translated:

image

Edit: However it is translated in Spanish:

image

Maybe there isn't a chinese word for graph 🤷
Worth double checking that it isn't a mistake. I haven't been involved with doing translations. Can someone in the know reach out to them and ask?

@RussKie RussKie merged commit 6c8ddfa into release/8.0 Apr 29, 2024
8 checks passed
@RussKie RussKie deleted the backport/pr-3408-to-release/8.0 branch April 29, 2024 08:06
@kvenkatrajan
Copy link
Member

Thanks @danmoseley , @JamesNK , @balachir

We were missing the translations 😄 .. fixed

Was this in a separate PR? How was this fixed?

I raised this in the original issue - #2877 - graph still isn't translated:

I have opened a ticket for this one to confirm : https://ceapex.visualstudio.com/CEINTL/_workitems/edit/968065

@danmoseley
Copy link
Member

Was this in a separate PR? How was this fixed?

I just copied the xlf files from main.

@kvenkatrajan
Copy link
Member

Ah ok so the translation came into main after we created the original PR. Ok makes sense. Thanks @danmoseley

@danmoseley
Copy link
Member

@danmoseley yes we do cover non-ENU configurations as well. @v-sherryfan @v-elenafeng fyi on this incoming fix for 8.0 GA. When verifying this, please test with non-ENU configurations too.

thanks, note they'll still see #4020. Question is is there anything else.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dashboard Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants