Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter additionals records from dns srv response #4463

Merged

Conversation

vha-schleupen
Copy link
Contributor

@vha-schleupen vha-schleupen commented Jun 11, 2024

In addition to address-records and cname-records, there can also be other record types in the additional field. This types must be ignored, otherwise the service can not be resolved. Fixes #4494

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 11, 2024
@vha-schleupen
Copy link
Contributor Author

@dotnet-policy-service agree company="Schleupen SE"

@sja-schleupen
Copy link

@davidfowl @ReubenBond any chance getting this reviewed and merged?

@ReubenBond ReubenBond changed the title filter additionals records from dns srv response Filter additionals records from dns srv response Aug 5, 2024
@ReubenBond ReubenBond merged commit 6a079db into dotnet:main Aug 5, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-service-discovery community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service discovery fails if the SRV response also contains TXT entries
3 participants