Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping dependency versions and updating Configuration Schema for components #4655

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Jun 25, 2024

In preparation for our 8.0.2 release, this change is updating all1 of our package dependencies to latest versions out in Nuget.org

cc: @eerhardt can you please review and make sure dependencies look correct?

FYI: @radical @danmoseley @DamianEdwards @davidfowl @maddymontaquila This is in preparation of our 8.0.2 release later this week.

Microsoft Reviewers: Open in CodeFlow

Footnotes

  1. With the exception of Azure.Open.AI package as that one is still in beta and new version has breaking changes that require more risk than what we want in this servicing.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 25, 2024
@joperezr joperezr requested a review from eerhardt June 25, 2024 21:27
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Jun 25, 2024
@joperezr joperezr requested a review from radical June 25, 2024 21:27
Directory.Packages.props Outdated Show resolved Hide resolved
@radical

This comment was marked as resolved.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth describing the process you used here? Eg link to the script.

@joperezr
Copy link
Member Author

joperezr commented Jun 26, 2024

Worth describing the process you used here? Eg link to the script.

Sure, I did the following:

# from the root of the repo
./build.cmd -restore # to ensure that we start off from a good point and dotnet-outdated can traverse dependencies.
dotnet new nugetconfig --force # to override the the NuGet.config with one that only has NuGet.org as the source
dotnet outdated --no-restore -u .\Aspire.sln # to perform the update of packages
git checkout -- NuGet.config # to undo the change to nuget.config file

## At this point the update is done, now we need to check if anything else needs updating (code or configuration schemas)
./build.cmd -restore -build # to validate things are working and if there are failures, then fix case-by-case.
                                           # When configurationschema files need an update, the build will fail and the command needed to
                                           # update them will be printed in the console.

If you don't have dotnet-outdated tool install yet, you can get it by following the steps on their repo: https://github.com/dotnet-outdated/dotnet-outdated

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

NuGet.config Show resolved Hide resolved
@joperezr joperezr enabled auto-merge (squash) June 26, 2024 16:16
@joperezr joperezr merged commit 3d0cf81 into dotnet:release/8.0 Jun 26, 2024
9 checks passed
@danmoseley
Copy link
Member

Sure, I did the following:

Ah, that's exactly what I was doing. sounds good

@danmoseley
Copy link
Member

do we want to pull any testing improvements from main into release/8.0 too? if they are separable and worthwhile. we have the playwright stuff, testcontainers stuff.

@joperezr
Copy link
Member Author

I think that most of that actually depends on a lot of infrastructure that is also only on main, and given the fact that we don't really plan on shipping from the release/8.0 branch, I'm not sure if it's worth the effort. For this particular servicing, I've already reached out to @balachir to have his team do a round of validation with 8.0.2 build to ensure things look great.

I do agree that moving forward, we'll want to more heavily rely on automation for coverage and not just our CTI team.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants