Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up from Keycloak PR #4988

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Follow up from Keycloak PR #4988

merged 2 commits into from
Jul 19, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Jul 19, 2024 •
edited by dotnet-policy-service bot
Loading

  • Remove unnecessary IVT
  • Remove unnecessary image tags
  • Fix up .sln file

cc @julioct

Microsoft Reviewers: Open in CodeFlow

@eerhardt eerhardt requested a review from radical July 19, 2024 19:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 19, 2024
@eerhardt eerhardt mentioned this pull request Jul 19, 2024
Merged
@radical
Copy link
Member

radical commented Jul 19, 2024

Build failed with tests/Aspire.Hosting.Keycloak.Tests/KeycloakResourceBuilderTests.cs(114,23): error CS0122: (NETCORE_ENGINEERING_TELEMETRY=Build) 'UserSecretsParameterDefault' is inaccessible due to its protection level

@eerhardt
Follow up from Keycloak PR
d7864cb 
- Remove unnecessary IVT
- Remove unnecessary image tags
- Fix up .sln file
@eerhardt
fix build
4eb4b70
@eerhardt
Copy link
Member Author

Build failed with tests/Aspire.Hosting.Keycloak.Tests/KeycloakResourceBuilderTests.cs(114,23): error CS0122: (NETCORE_ENGINEERING_TELEMETRY=Build) 'UserSecretsParameterDefault' is inaccessible due to its protection level

fixed.

@eerhardt eerhardt merged commit 4abad17 into dotnet:main Jul 19, 2024
9 checks passed
@eerhardt eerhardt deleted the FixUpKeycloakPR branch July 19, 2024 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @radical