Extract Aspire.Hosting.MongoDB.Tests project #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
20 tasks
radical
added
area-app-model
sebastienros
force-pushed
the
mongodb-tests
branch
from
c42fba0
to
a6b8a9a
Compare
|
Maybe tests have feelings and don't like me. |
eerhardt
reviewed
Jul 31, 2024
Comment on lines
+147
to
+148
| //mongodb shutdown has delay,so without delay to running instance using same data and second instance failed to start. | ||
| await Task.Delay(TimeSpan.FromSeconds(10)); |
There was a problem hiding this comment.
We need to make this more deterministic. Waiting for X seconds is usually how we get random/flakey failures.
There was a problem hiding this comment.
What's your suggestion?
I don't have any idea.
There was a problem hiding this comment.
Try to connect to the database until it fails?
There was a problem hiding this comment.
Is there any helper method exists to check container is fully stopped?
There was a problem hiding this comment.
I was expecting something like #4878. If you want to prototype trying to make that work. cc @karolz-ms @DamianEdwards
There was a problem hiding this comment.
@sebastienros - should we log an issue for this wait case, and then we can merge this PR?
Co-authored-by: Eric Erhardt <[email protected]>
I will check. |
|
Seems the test failed on Linux how can i see container logs? |
Here's how I do it. I'm not sure if there is a faster way:
Then find the appropriate test under here:
|
|
@eerhardt I can't open it! |
Hmm, does it work if you "log in" (using any Microsoft account)? |
|
Here's the log output: |
didn't work |
Thanks, maybe i need logs again. |
I got an answer from some of my team members that if you aren't a Microsoft employee, you can download the whole artifacts by click the little three dots on the right:
That will get you all the artifacts for that leg. |
…to mongodb-tests
eerhardt
reviewed
Aug 6, 2024
tests/Aspire.Hosting.MongoDB.Tests/Aspire.Hosting.MongoDB.Tests.csproj
Outdated
Show resolved
Hide resolved
|
|
||
| if (!OperatingSystem.IsWindows()) | ||
| { | ||
| System.Diagnostics.Process.Start("/usr/bin/env", $"sudo chmod -R a+rwx {bindMountPath}").WaitForExit(); |
There was a problem hiding this comment.
Why can't this use File.SetUnixFileMode?
There was a problem hiding this comment.
Maybe we shouldn't use Directory.CreateTempSubdirectory() in this case since we need other users to be able to see it? Directory.CreateTempSubdirectory() explicitly only gives the current user access to the directory, for security reasons. We might as well make a normal folder if we need other users to access it.
eerhardt
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3185
Contributes to #4294
Fixes #5184
Microsoft Reviewers: Open in CodeFlow