Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling AOAI resource key access by default. #5041

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Jul 24, 2024

Updated test for bicep changed and added test for property override.

Fixes #5040

Microsoft Reviewers: Open in CodeFlow

Updated test for bicep changed and added test for property override.

Fixes dotnet#5040
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2024
@eerhardt eerhardt self-requested a review July 29, 2024 23:15
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product change looks good to me. I just have one question about the test code.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@eerhardt eerhardt merged commit 8afad96 into dotnet:main Aug 1, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure OpenAI resources deploy with keys enabled but use Managed Identity
2 participants