Prepare playground apps to allow testing #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. with `.AppHost` suffix. `Aspire.Hosting.Testing` specifically looks for a `.AppHost` suffix to identify apphost assemblies.
And use Aspire.RepoTesting.* to allow testing and this replaces the per-project sdk imports.
dotnet-issue-labeler
bot
added
the
area-integrations
…ference. And skip Dashboard.csproj when building for testing
|
TODO
|
eerhardt
reviewed
Jul 30, 2024
.. `playground` `AppHost` projects by default, instead of doing that individually in the project files.
.. automatically on `@(AspireProjectOrPackageReference)` items used in `AppHost` projects.
Instead of copying `src/Shared` to the test archive, keep a copy of `src/Shared/KnownResourceNames.cs` in `playground` and use that instead.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes to prepare the
playground/apps to be run as part of future tests inAspire.Playground.Tests. The changes follow these broad patterns:remove all the per-project
Directory.Build.{props,targets}, and instead of these ..Directory.Build.{props,targets}and useAspire.RepoTesting.*AspireProjectOrPackageReferenceinstead ofProjectReferenceAspire.Hosting.Testingexpects to identify AppHost assemblies by a name ending in.AppHost.Update the apps to use
Aspire.RepoTesting*which allows building outside of repo.Microsoft Reviewers: Open in CodeFlow