[release/8.1] Extract Aspire.Hosting.Azure.Tests #5090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributes to #4294 This also allows us to remove the Aspire.Hosting.Tests.SharedShim, now that VolumeNameGenerator is only found in Aspire.Hosting.
dotnet-issue-labeler
bot
added
the
area-integrations
* Extract Aspire.Hosting.MySql.Tests * Improve reliability * Record Docker logs * Fix ResourceLoggerForwarderService link in Aspire.Hosting.PostgreSQL.csproj * Remove E2E tests * Fix manifest test * Fix tests * Increase delay between retries * Create mount path directory * Address PR feedback * Use Directory.Delete * Use Linear backoff --------- Co-authored-by: Ankit Jain <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> (cherry picked from commit 5238a73)
joperezr
requested changes
Jul 26, 2024
dotnet-policy-service
bot
added
the
needs-author-action
|
Closing, as we don't plan on shipping this branch again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5013, and #4925 to release/8.1 . The latter is required for for the former to build successfully.
/cc @eerhardt
Customer Impact
The engineering team can write tests easier and be more confident in shipping releases.
For example, we can backport the tests added in Fix Azure Storage
RunAsEmulator(dotnet/aspire#5084).Testing
These are the tests you are looking for.
Risk
Very minimal. No product code changes. Only removing InternalsVisibleTo tests and splitting code to new files.
Regression?
Microsoft Reviewers: Open in CodeFlow