Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter dashpages to show only available ones #5337

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Filter dashpages to show only available ones #5337

merged 1 commit into from
Aug 20, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Aug 19, 2024 •
edited by dotnet-policy-service bot
Loading

Fixes #5295

The list of available dashpages in the Metrics UI is dynamic, depending on the selected resource.

A dashpage will only be shown if:

  • metrics are available for at least one chart, and
  • all required metrics are available
  • all required resources are available

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected. This is a feature branch.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No (though dashpages will be documented when the feature branch merges)
Microsoft Reviewers: Open in CodeFlow

@drewnoakes
Filter dashpages to show only available ones
cea9819 
The list of available dashpages in the Metrics UI is dynamic, depending on the selected resource.

A dashpage will only be shown if:

- metrics are available for at least one chart, and
- all required metrics are available
- all required resources are available
@build-analysis build-analysis bot mentioned this pull request Aug 19, 2024
Closed
3 tasks
@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drewnoakes
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 20, 2024
Open
3 tasks
@adamint
Copy link
Member

adamint commented Aug 20, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@drewnoakes drewnoakes merged commit 06532fb into dotnet:feature/dashpages Aug 20, 2024
7 of 10 checks passed
@drewnoakes drewnoakes deleted the drnoakes/filter-dashpages branch August 20, 2024 03:25
@drewnoakes drewnoakes mentioned this pull request Aug 21, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamint adamint adamint approved these changes

Assignees
No one assigned
Labels
dashboard-dashpages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewnoakes @adamint